Adds clang and sanitizers #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds behaviour to checkout custom branches by name. - Replaces path references to dsim-repos-index to configure the workspace.
Merged
|
it looks like the two failures are from maliput/delphyne#713 should we disable that test until we have a fix for it? |
scpeters
reviewed
Dec 10, 2020
.github/workflows/sanitizers.yml
Outdated
| - master | ||
| pull_request: | ||
| schedule: | ||
| - cron: '0 9 * * *' # 9:00am UTC, 1:00am PST. |
There was a problem hiding this comment.
running clang and the sanitizers every night will multiply my previous estimate of usage time by 4
should we consider only testing gcc for the nightly?
There was a problem hiding this comment.
Moved to a weekly test.
scpeters
approved these changes
Dec 14, 2020
Done in maliput/delphyne#736 |
|
I've triggered CI again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #143
Part of #136