Includes ign-gui as a temporary dependency #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… migration to newer versions of ignition happens.
|
@jadecastro the problem seemed to be that github ci dependencies and the one used for the workspace got out of sync. We'll be more careful from now on with that. |
jadecastro
suggested changes
Dec 22, 2020
jadecastro
approved these changes
Dec 22, 2020
|
this was an oversight on my part in #152 actually, it would be preferable to use |
👍 |
|
I am not sure why I cannot merge this PR. Github does not offer me the green button even with @jadecastro's approval. Requesting @francocipollone 's review. |
francocipollone
approved these changes
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It'll be around until the migration is complete in delphyne-gui to the new set of ign packages.