Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds TownXX maps to integration tests. #145

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

francocipollone
Copy link
Collaborator

@francocipollone
Copy link
Collaborator Author

francocipollone commented Aug 5, 2021

CI is failing during RoadNetworkBuilderTest when checking invariants for Town11 map
https://github.com/ToyotaResearchInstitute/maliput_malidrive/pull/145/checks?check_run_id=3256012617#step:15:11341

Interesting, will check

EDITED:

It isn't because of actual invariants but because of failure in the orientation method similarly to maliput/delphyne_demos#17 (comment)

[OrientationOutFromLane] lane: 682_0_1
[OrientationOutFromLane] lanened: Finish
unknown file: Failure
C++ exception with description "road_curve.cc:Orientation:108: 19.383793 is greater than 19.309339" thrown in the test body.

@francocipollone
Copy link
Collaborator Author

francocipollone commented Aug 5, 2021

This is easily reproducible with maliput_query app as follow:

  1. Get lane length:
maliput_query GetLaneLength 682_0_1 -xodr_file_path=Town11.xodr --linear_tolerance=0.16
Lane length for  682_0_1:    [22.7933]
  1. Then query the orientation at the end:
maliput_query GetOrientation 682_0_1  22.7933 0 0 -xodr_file_path=Town11.xodr --linear_tolerance=0.16
terminate called after throwing an instance of 'maliput::common::assertion_error'
  what():  road_curve.cc:Orientation:108: 19.383793 is greater than 19.309339

The s value(22.7933) is traduced to p value(19.383793) and then it trhows at: https://github.com/ToyotaResearchInstitute/maliput_malidrive/blob/main/maliput_malidrive/src/maliput_malidrive/road_curve/road_curve.cc#L108


I've created #146 to track this bug

@francocipollone
Copy link
Collaborator Author

This PR will mutate to only add Towns from 1 to 7 and then a follow-up PR will add Town11 after we solve #146

@francocipollone
Copy link
Collaborator Author

@agalbachicar Ready to review

@francocipollone francocipollone added do-clang-test Triggers clang builds in a pull request do-static-analyzer-test Runs scan-build workflow labels Aug 12, 2021
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit 30ff6fd into main Aug 13, 2021
@francocipollone francocipollone deleted the francocipollone/map_coverage branch August 13, 2021 12:42
@francocipollone francocipollone mentioned this pull request Aug 23, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-clang-test Triggers clang builds in a pull request do-static-analyzer-test Runs scan-build workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants