-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes include folder installation. #220
Fixes include folder installation. #220
Conversation
Signed-off-by: Franco Cipollone <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This won't pass CI until maliput/maliput_drake#23 or maliput/maliput#508 (review) are merged, released, and rebuilt.
|
|
You can request a retry from Jenkins by commenting here like this. @ros-pull-request-builder retest this please |
The build passed, but has linter errors which are why it shows error now. |
Is it a requirement to fix all the warnings? What's the best approach when using marked-as-deprecated api? CC: @agalbachicar |
Signed-off-by: Franco Cipollone <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]>
cbe4a2c
to
0463a34
Compare
Issues were solved via 221 and 222. When merging we should: Rebase and Merge |
@tfoote Issues are resolved! https://build.ros2.org/job/Fpr__maliput_malidrive__ubuntu_focal_amd64/8/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad it wasn't too much to clear the warnings.
Part of maliput/maliput_infrastructure#275
action-ros-ci-override: https://gist.githubusercontent.com/francocipollone/18dfba70fefe81314bc8a68138732f53/raw/f87e9a6f8e2a6241fbe79db063158bfca5972b41/prs.repos