-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uses ros-action-ci in build.yaml workflow. #59
Conversation
I've been trying this feature of the ros-action-ci but it doesn't seem to be working: https://github.com/ros-tooling/action-ros-ci#interdependent-pull-requests-or-merge-requests |
I've seen it in a code block. Have you tried it? |
Let's see |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add me as reviewer when you've found a solution. Otherwise, I can allocate some time to investigate further.
9669f64
to
bfe9368
Compare
Signed-off-by: Franco Cipollone <[email protected]>
bfe9368
to
589d703
Compare
It is working now! @agalbachicar Some things to have mind with this tool
For the record:I've found some PRs(See here) where this was being used (By the very feature's creator) and from there I got the confirmation on the expected PR's description syntaxis. |
I suggest we add a TODO in maliput_documentation and explain how to use it in the developer guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Done! maliput/maliput_documentation#91 Going in |
Part of maliput/maliput_infrastructure#268 (comment)
Part of maliput/maliput_infrastructure#274
Rely on
ros-action-ci
for thebuild.yaml
workflowaction-ros-ci-repos-override: https://gist.githubusercontent.com/francocipollone/18dfba70fefe81314bc8a68138732f53/raw/6ca6e0def9d90e93d84d7ce20ad99c437bdd0e7a/prs.repos
Signed-off-by: Franco Cipollone [email protected]