Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to vcpkgs "subprocess" implementation #426

Closed
wolfv opened this issue Jul 24, 2020 · 8 comments
Closed

Move to vcpkgs "subprocess" implementation #426

wolfv opened this issue Jul 24, 2020 · 8 comments

Comments

@wolfv
Copy link
Member

wolfv commented Jul 24, 2020

We're currently using a subprocess implementation that isn't very much battle-tested on Windows.

VCPKG has a really nice implementation that I hope we could easily re-use: https://github.com/microsoft/vcpkg/blob/master/toolsrc/include/vcpkg/base/system.process.h

@wolfv
Copy link
Member Author

wolfv commented Jul 26, 2020

https://github.com/benman64/subprocess/ this looks like another decent alternative

@traversaro
Copy link
Member

Other related libraries (not sure if they suit all mamba's needs):

If gazebosim/gazebo-classic#2864 gets merged, I plan to add tiny-process-library to conda-forge .

@wolfv
Copy link
Member Author

wolfv commented Nov 5, 2020

@traversaro did you start packaging the tiny-process-library already? I am quite interested as well, as I am having some issues with the current implementation on Windows.

@traversaro
Copy link
Member

traversaro commented Nov 5, 2020

I was waiting for upstream to merge https://gitlab.com/eidheim/tiny-process-library/-/merge_requests/38 , but that is not strictly necessary, we could start packaging it in any case or keeping that patch local for now. However I did not worked on it for now.

@wolfv
Copy link
Member Author

wolfv commented Nov 5, 2020

@traversaro I checked tiny-process-library and saw that it requires MSYS2.

For now I am trying reproc++ in #569 and it's already better working vs what I had before :)
I think I am going to package reproc for conda-forge -- thanks for the pointers!

@traversaro
Copy link
Member

@traversaro I checked tiny-process-library and saw that it requires MSYS2.

To clarify, MSYS2 support in tiny-process-library is optional, and it works fine even without MSYS2. In any case, that's not a big problem, both reproc++ and tiny-process-library are small libraries that do one job in a great way, and it will be great to have both of them in conda-forge .

@wolfv
Copy link
Member Author

wolfv commented Nov 5, 2020

yeah I am trying to get reproc on conda-forge :) conda-forge/staged-recipes#13113

@wolfv
Copy link
Member Author

wolfv commented Nov 10, 2020

we've completed the transition to reproc for now. Hopefully it works well enough and I never have to touch this again 😅

@wolfv wolfv closed this as completed Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants