Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproc to call subprocesses cross platform (useful for micromamba) #13113

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Nov 5, 2020

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/reproc) and found some lint.

Here's what I've got...

For recipes/reproc:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [25, 45, 66, 89]
  • There are 1 too many lines. There should be one empty line at the end of the file.

For recipes/reproc:

  • It looks like the 'reproc-cpp' output doesn't have any tests.
  • It looks like the 'reproc-cpp-static' output doesn't have any tests.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/reproc) and found some lint.

Here's what I've got...

For recipes/reproc:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [25, 45, 68, 91]
  • There are 1 too many lines. There should be one empty line at the end of the file.

For recipes/reproc:

  • It looks like the 'reproc-cpp' output doesn't have any tests.
  • It looks like the 'reproc-cpp-static' output doesn't have any tests.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/reproc) and found it was in an excellent condition.

@wolfv
Copy link
Member Author

wolfv commented Nov 6, 2020

@ocefpaf ocefpaf merged commit a911e1f into conda-forge:master Nov 6, 2020
@wolfv wolfv deleted the reproc branch November 6, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants