1.x: Fix repoquery subcommand for Python 3.11/3.12 #3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Bargull <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
mbargull
changed the title
3 tasks
|
Thanks! |
2 tasks
|
Good catch @mbargull! |
jezdez
reviewed
Mar 5, 2024
| @@ -778,7 +778,7 @@ def format_param(nm, val): | |||
| " deactivate are supported through mamba." | |||
| ) | |||
|
|
|||
| return 0 | |||
| return 1 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a small typo in gh-3036 which caused the
args.func == ".repoquery"case to not be caught.For Python versions prior to 3.11 the
args._plugin_subcommand == ".main_repoquery"case has been handled correctly which is why we didn't see problems withmamba repoqueryfor those versions.Our tests did not catch this since
mambareturned a zero exit code in case of not recognized commands.This PR changes it to return exit code
1in these cases now.(N.B.: Cases like
mamba completely-unknown-commandare handled with non-zero exit code byargparse.)Fixes gh-2994 .
Fixes gh-3033 .