Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows shell init files use executable name #3546

Merged
merged 16 commits into from
Oct 21, 2024

Conversation

Klaim
Copy link
Member

@Klaim Klaim commented Oct 17, 2024

  • shell-init: Windows bat paths are factorized and depend on exe name (micromamba or mamba) except for mamba_hook.bat which for now needs to keep that name whatever the exe name;
  • Fixed windows version detection: When more than one line of output appears at the start of cmd (because of AUTORUN), we parsed only the first line which failed the version detection. This version simply search every line instead of just the first one.
    It also clarifies through more precise logs the exact reason why enabling long-paths actually failed.
  • Improved error output for clarity on failure to create shell-init files (.bat) or directories.

@Klaim Klaim added the release::bug_fixes For PRs fixing bugs label Oct 17, 2024
@Klaim Klaim force-pushed the klaim/windows-shell-init branch 2 times, most recently from a5c7f59 to 00cf99c Compare October 21, 2024 08:27
@Klaim Klaim marked this pull request as ready for review October 21, 2024 09:31
@JohanMabille JohanMabille merged commit 651622b into mamba-org:main Oct 21, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release::bug_fixes For PRs fixing bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants