Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PAM authentication log message #526

Merged
merged 1 commit into from
May 2, 2022
Merged

Conversation

riccardoporreca
Copy link
Contributor

Missing f-string and spacing

Missing f-string and spacing
@riccardoporreca
Copy link
Contributor Author

Happy to also convert the % formatting of other log messages to f strings for consistency

@wolfv
Copy link
Member

wolfv commented May 2, 2022

@riccardoporreca if you want to tackle other strings to convert them to f"... that would be great.
Thansk for this PR!

@wolfv wolfv added the bug Something isn't working label May 2, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #526 (41d80af) into main (05dbfc6) will decrease coverage by 1.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #526      +/-   ##
==========================================
- Coverage   83.16%   81.94%   -1.22%     
==========================================
  Files          78       78              
  Lines        5916     5916              
==========================================
- Hits         4920     4848      -72     
- Misses        996     1068      +72     
Impacted Files Coverage Δ
quetz/authentication/pam.py 82.71% <ø> (ø)
quetz/pkgstores.py 42.45% <0.00%> (-11.60%) ⬇️
quetz/database.py 83.33% <0.00%> (-4.17%) ⬇️
quetz/dao.py 88.51% <0.00%> (-2.58%) ⬇️
quetz/testing/fixtures.py 97.38% <0.00%> (-1.31%) ⬇️
quetz/jobs/runner.py 89.61% <0.00%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05dbfc6...41d80af. Read the comment docs.

@wolfv wolfv merged commit 59adbfd into mamba-org:main May 2, 2022
@riccardoporreca riccardoporreca deleted the patch-1 branch May 2, 2022 16:02
riccardoporreca added a commit to riccardoporreca/quetz that referenced this pull request May 30, 2022
* Fix missing `f` for massage strings with placeholders otherwise unresolved.
* Favor f-strings over `.format()` when sensible to do so.
* Follow-up from mamba-org#526.
riccardoporreca added a commit to riccardoporreca/quetz that referenced this pull request May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants