Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes CI #559

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Fixes CI #559

merged 2 commits into from
Sep 19, 2022

Conversation

hbcarlos
Copy link
Collaborator

@hbcarlos hbcarlos commented Sep 18, 2022

This PR pins FastAPI to check whether the error comes from this release of FastAPI

Removes response_model from endpoints that don't return anything.
We could also use response_mode=None.

@hbcarlos hbcarlos added bug Something isn't working maintenance labels Sep 18, 2022
@hbcarlos hbcarlos self-assigned this Sep 18, 2022
@hbcarlos hbcarlos marked this pull request as draft September 18, 2022 19:27
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2022

Codecov Report

Base: 82.90% // Head: 82.04% // Decreases project coverage by -0.85% ⚠️

Coverage data is based on head (992c995) compared to base (d250338).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
- Coverage   82.90%   82.04%   -0.86%     
==========================================
  Files          78       78              
  Lines        5977     5987      +10     
==========================================
- Hits         4955     4912      -43     
- Misses       1022     1075      +53     
Impacted Files Coverage Δ
quetz/dao.py 91.12% <100.00%> (+0.03%) ⬆️
quetz/main.py 86.85% <100.00%> (+0.14%) ⬆️
quetz/pkgstores.py 42.45% <0.00%> (-11.60%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hbcarlos hbcarlos marked this pull request as ready for review September 18, 2022 20:34
@brichet
Copy link
Collaborator

brichet commented Sep 19, 2022

Thanks @hbcarlos

@brichet brichet merged commit 1467892 into mamba-org:main Sep 19, 2022
@hbcarlos hbcarlos deleted the fix_ci branch September 19, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants