Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mame adds "0" to end of the file extension with "-snapview native" enabled #10005

Closed
cd4053 opened this issue Jun 29, 2022 · 6 comments
Closed

Mame adds "0" to end of the file extension with "-snapview native" enabled #10005

cd4053 opened this issue Jun 29, 2022 · 6 comments
Assignees
@cuavas

Comments

@cd4053
Copy link

cd4053 commented Jun 29, 2022

mame: 0.244 (mame0244-430-g5d31d021d23)
OS: Windows 10 21H2

command: mame sf2 -snapview native -aviwrite test.avi

The result is a filename test.avi0, removing -snapview native it creates the correct test.avi. The other modes (auto, internal, pixel) causes no issues.
@cuavas
Copy link
Member

cuavas commented Jun 29, 2022

Remember -snapview native needs to mangle the snapshot names as it produces multiple output files if the system has multiple screens.

What if you just use -aviwrite test? Will it call the file test0.avi in that case, or will the file just be called test0?

@cd4053
Copy link
Author

cd4053 commented Jun 29, 2022 •
edited
Loading

Remember -snapview native needs to mangle the snapshot names as it produces multiple output files if the system has multiple screens.

Thank you, I'll use other modes then.

What if you just use -aviwrite test? Will it call the file test0.avi in that case, or will the file just be called test0?

Using -aviwrite test it produces a file named test0, without the .avi extension.

@cuavas cuavas self-assigned this Jun 29, 2022
@cuavas
Copy link
Member

cuavas commented Jun 29, 2022

I’ll look at this later. It’s not top priority, but it should still be addressed.

@cd4053
Copy link
Author

cd4053 commented Jun 29, 2022

Thanks.

cuavas added a commit that referenced this issue Jul 1, 2022
@cuavas
emu: Fixed issues with memory views and snapshot naming.
875ee33 
Include device tag in memory view save item registration names.  Without
this, instantiating two of the same device (or two devices with
identically named memory views) causes a fatal error on start.

Fixed -aviwrite/-mngwrite with -snapview native more than two screens.
Previously it would attempt to use the same file name for all screens
but the first.

Improved naming of snapshots, especially when using -snapview native
with -aviwrite/-mngwrite (see GitHub #10005).  The automatically
included screen number should come before the extension if supplied.
Also, assume that users actually know what they’re doing if they include
a dot in a snapshot filename pattern.
@cuavas
Copy link
Member

cuavas commented Jul 1, 2022

Fixed in 875ee33. For a system with a single screen (or no screens), it will produce test.avi. For systems with multiple screens, it will produce test0.avi, test1.avi, etc.

@cuavas cuavas closed this as completed Jul 1, 2022
@cd4053
Copy link
Author

cd4053 commented Jul 1, 2022

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cuavas cuavas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cuavas @cd4053