mc10: Create slot system #8184
Merged
mc10: Create slot system #8184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tlindner
commented
Jun 13, 2021
tlindner
commented
- Turn MCX-128 and Alice 128 drivers into cartridges loaded on an MC-10 and Alice.
- Create RAM cartridges
- Clean up MC-10 and Alice drivers
cuavas
requested changes
Jun 13, 2021
src/devices/bus/mc10/mc10cart.cpp
Outdated
Comment on lines
30
to
31
| SEL is an input to the MC-10 that allows the cartridge to remove | ||
| the internal chips from the bus. |
There was a problem hiding this comment.
Can hardware in the cartridge control SEL on-the-fly? If it can, the host should probably install the chips affected by it in a view so it can unmap them when necessary.
There was a problem hiding this comment.
Yes. I see the logic in your suggestion, but that adds a view that has to be explicitly manager by trampolines. By having the slot device create the view, it can control access to the internal bus in exactly the same way the hardware does.
Imho the |
cuavas
reviewed
Jun 15, 2021
cuavas
reviewed
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.