bus/nes: Support full 12-bit mapper numbers in NES 2.0 loader. #8281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajrhacker
reviewed
Jul 11, 2021
0kmg
force-pushed
the
nes-12-bit-mapper-nos
branch
from
71e162d
to
59d0dbf
Compare
…p for some mappers > 255
0kmg
force-pushed
the
nes-12-bit-mapper-nos
branch
from
a67cd95
to
2220f63
Compare
|
Thank you very much for merging this, @cuavas! This will make adding support for more recent dumps much easier as I can now test against .nes files without the tedium of first having to split roms, add softlist entries, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the loader from silently loading mapper numbers modulo 256. It hooks up a skeleton list of mappers > 255 for loading loose .nes files and correctly aborts for those not hooked up.