Improve console shutdown #2016
Merged
Improve console shutdown #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Him188
reviewed
May 14, 2022
Karlatemp
force-pushed
the
console/console-shutdown
branch
from
bae893b
to
df485c2
Compare
Him188
reviewed
May 16, 2022
mirai-console/backend/mirai-console/src/internal/plugin/JvmPluginInternal.kt
Show resolved
Hide resolved
mirai-console/backend/mirai-console/src/internal/MiraiConsoleImplementationBridge.kt
Show resolved
Hide resolved
Him188
approved these changes
May 16, 2022
Karlatemp
force-pushed
the
console/console-shutdown
branch
from
df485c2
to
c862759
Compare
Karlatemp
force-pushed
the
console/console-shutdown
branch
from
c862759
to
12d46d7
Compare
Closed
Him188
approved these changes
May 29, 2022
Open
Karlatemp
force-pushed
the
console/console-shutdown
branch
from
3aae12e
to
11f50c6
Compare
|
没问题了就可以合 |
cssxsh
pushed a commit
to SkyNet1748/mirai
that referenced
this pull request
Jul 20, 2022
* Try to improve console shutdown * Resetting & Better java calling * Dump crash report when timed out to shutdown * Ensure `CoroutineScope.cancel()` working; rename to `shutdown` * Signal handlers * Force halt system to avoid some magic errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
尝试缓解 #1959
MiraiConsole.shutdownConsole()java.desktop/java.awt.Window.dispose()