RoamingSupported for Group
#2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Him188
requested review from
Him188 and
Karlatemp
and removed request for
Him188
Him188
reviewed
Dec 17, 2022
mirai-core/src/commonMain/kotlin/contact/roaming/RoamingMessagesImpl.kt
Outdated
Show resolved
Hide resolved
Karlatemp
reviewed
Dec 18, 2022
mirai-core/src/commonMain/kotlin/contact/roaming/RoamingMessagesImplGroup.kt
Show resolved
Hide resolved
mirai-core/src/jvmBaseMain/kotlin/contact/roaming/TimeBasedRoamingMessagesImpl.kt
Outdated
Show resolved
Hide resolved
Closed
Karlatemp
approved these changes
Jan 1, 2023
Karlatemp
added
t:enhancement
…pl. Extract RoamingMessagesImplFriend
… for group: - Added `RoamingMessagesImplGroup`. - Dump API changes for Group RoamingMessages. - [mock] Fix MockRoamingMessages missing MessageSource - [core] Convert hierarchical TimeBasedRoamingMessagesImpl to common, to reduce code complexity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
已经写好了，但是 test 和 mock 部分还没完成。
通过
MessageSvc.PbGetGroupMsg指令传递 msgSeq 获取消息，然后通过判断MsgComm.Msg.msgHead.msgTime来截取需要的消息。