Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: AutoLoginEvent.toString #2750

Merged
merged 4 commits into from
Jul 26, 2023
Merged

feat: AutoLoginEvent.toString #2750

merged 4 commits into from
Jul 26, 2023

Conversation

cssxsh
Copy link
Contributor

@cssxsh cssxsh commented Jul 24, 2023

No description provided.

Karlatemp
Karlatemp reviewed Jul 25, 2023
View reviewed changes
Copy link
Member

@Karlatemp Karlatemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接在公共父类用 instanceof 判断并不是什么好做法

@Karlatemp Karlatemp added this to the 2.16.0-RC milestone Jul 26, 2023
@Karlatemp Karlatemp added t:enhancement 类型: 现有功能上的优化 z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排 s:console 子系统: mirai-console labels Jul 26, 2023
@Karlatemp Karlatemp merged commit d93b55f into mamoe:dev Jul 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karlatemp Karlatemp Karlatemp approved these changes

Assignees
No one assigned
Labels
s:console 子系统: mirai-console t:enhancement 类型: 现有功能上的优化 z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排
Projects
None yet
Milestone
2.16.0-RC
Development

Successfully merging this pull request may close these issues.
2 participants
@cssxsh @Karlatemp