Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core]修复从可确定图片类型的字符串组成的mirai code构造的图片type为UNKNOW或与期望类型不一致 #2761

Merged
merged 4 commits into from
Aug 12, 2023
Merged

[core]修复从可确定图片类型的字符串组成的mirai code构造的图片type为UNKNOW或与期望类型不一致 #2761

merged 4 commits into from
Aug 12, 2023

Conversation

Hamusuta0320
Copy link
Contributor

fix #2760

Him188
Him188 reviewed Jul 30, 2023
View reviewed changes
Copy link
Member

@Him188 Him188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请添加单元测试

mirai-core-api/src/commonMain/kotlin/message/data/Image.kt Outdated Show resolved Hide resolved
@Him188
Copy link
Member

Him188 commented Jul 30, 2023

测试失败了

LongMessageProtocolTest > can convert messages to LongMessageInternal() FAILED
    org.opentest4j.AssertionFailedError at LongMessageProtocolTest.kt:68

改完请使用 ./gradlew check 测试通过后再提交

@Him188 Him188 requested a review from Karlatemp August 7, 2023 05:15
@Him188 Him188 added this to the 2.16.0-RC milestone Aug 7, 2023
@Him188 Him188 added t:bug 类型: bug s:core 子系统: mirai-core labels Aug 7, 2023
Karlatemp
Karlatemp approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@Karlatemp Karlatemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format

@Him188 Him188 added this pull request to the merge queue Aug 12, 2023
@Him188 Him188 removed this pull request from the merge queue due to a manual request Aug 12, 2023
@Him188 Him188 merged commit e61b058 into mamoe:dev Aug 12, 2023
1 check passed
@gebederry gebederry mentioned this pull request Sep 20, 2023
Open
@Natsukage Natsukage mentioned this pull request Oct 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Him188 Him188 Him188 requested changes

@Karlatemp Karlatemp Karlatemp approved these changes

Assignees
No one assigned
Labels
s:core 子系统: mirai-core t:bug 类型: bug
Projects
None yet
Milestone
2.16.0-RC
Development

Successfully merging this pull request may close these issues.

用deserializeMiraiCode获得的图片消息，图片格式不准确
3 participants
@Hamusuta0320 @Him188 @Karlatemp