You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This feature is in the v2 API, and it has happy-path tests that ensure that it fundamentally works, however it is not sufficiently tested to really recommend its use. It should have simple hypothesis tests that generate dataframes with overlapping columns and new columns with overlapping dates, and then checks that they correspond to the output that pandas would produce
#### Reference Issues/PRs
Relates to [#1679](#1679)
#### What does this implement or fix?
#### Any other comments?
#### Checklist
<details>
<summary>
Checklist for code changes...
</summary>
- [ ] Have you updated the relevant docstrings, documentation and
copyright notice?
- [ ] Is this contribution tested against [all ArcticDB's
features](../docs/mkdocs/docs/technical/contributing.md)?
- [ ] Do all exceptions introduced raise appropriate [error
messages](https://docs.arcticdb.io/error_messages/)?
- [ ] Are API changes highlighted in the PR description?
- [ ] Is the PR labelled as enhancement or bug so it appears in
autogenerated release notes?
</details>
<!--
Thanks for contributing a Pull Request to ArcticDB! Please ensure you
have taken a look at:
- ArcticDB's Code of Conduct:
https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md
- ArcticDB's Contribution Licensing:
https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing
-->
---------
Co-authored-by: Vasil Pashov <[email protected]>
Describe the bug
This feature is in the v2 API, and it has happy-path tests that ensure that it fundamentally works, however it is not sufficiently tested to really recommend its use. It should have simple hypothesis tests that generate dataframes with overlapping columns and new columns with overlapping dates, and then checks that they correspond to the output that pandas would produce
Issues
sort_and_finalize_staged_data
is used #1738sort_and_finalize_staged_data
is called #1735sort_and_finalize_staged_data
with staged segment of DataFrame with 0 rows fails #1736sort_and_finalize_staged_data
throws non informative exception #1737compact_incomplete
withappend=True
should fail if dynamic schema is false and incomplete segment fields do not exactly match the existing fields #1466Note: All issues related to adding empty df, 0-row df, etc... are probably broken with the old API as well. They should at least be tested.
Steps/Code to Reproduce
run sort_and_finalize_staged_data
Expected Results
tests
OS, Python Version and ArcticDB Version
All versions
Backend storage used
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: