Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort_and_finalize_staged_data is not properly tested #1679

Closed
4 of 10 tasks
willdealtry opened this issue Jul 11, 2024 · 0 comments
Closed
4 of 10 tasks

sort_and_finalize_staged_data is not properly tested #1679

willdealtry opened this issue Jul 11, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request epic Parent issue

Comments

@willdealtry
Copy link
Collaborator

willdealtry commented Jul 11, 2024

Describe the bug

This feature is in the v2 API, and it has happy-path tests that ensure that it fundamentally works, however it is not sufficiently tested to really recommend its use. It should have simple hypothesis tests that generate dataframes with overlapping columns and new columns with overlapping dates, and then checks that they correspond to the output that pandas would produce

Issues

Note: All issues related to adding empty df, 0-row df, etc... are probably broken with the old API as well. They should at least be tested.

Steps/Code to Reproduce

run sort_and_finalize_staged_data

Expected Results

tests

OS, Python Version and ArcticDB Version

All versions

Backend storage used

No response

Additional Context

No response

@willdealtry willdealtry added the bug Something isn't working label Jul 11, 2024
@alexowens90 alexowens90 added enhancement New feature or request and removed bug Something isn't working labels Jul 18, 2024
vasil-pashov added a commit that referenced this issue Aug 6, 2024
#### Reference Issues/PRs
Relates to [#1679](#1679)

#### What does this implement or fix?

#### Any other comments?

#### Checklist

<details>
  <summary>
   Checklist for code changes...
  </summary>
 
- [ ] Have you updated the relevant docstrings, documentation and
copyright notice?
- [ ] Is this contribution tested against [all ArcticDB's
features](../docs/mkdocs/docs/technical/contributing.md)?
- [ ] Do all exceptions introduced raise appropriate [error
messages](https://docs.arcticdb.io/error_messages/)?
 - [ ] Are API changes highlighted in the PR description?
- [ ] Is the PR labelled as enhancement or bug so it appears in
autogenerated release notes?
</details>

<!--
Thanks for contributing a Pull Request to ArcticDB! Please ensure you
have taken a look at:
- ArcticDB's Code of Conduct:
https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md
- ArcticDB's Contribution Licensing:
https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing
-->

---------

Co-authored-by: Vasil Pashov <[email protected]>
@vasil-pashov vasil-pashov added the epic Parent issue label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request epic Parent issue
Projects
None yet
Development

No branches or pull requests

3 participants