32bit support #179
Open
32bit support #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Klaim
commented
Aug 14, 2024
•
Klaim
commented
- CI builds and tests 32bit flavor of the current configurations (assuming all host platforms are 64bit)
- Windows builds
- Linux builds
- MacOS builds
- fix 32 bit support fails #175 :
- support 32bit-only sizes
- provides a way for user to specify if they want to enable 64bit sizes on 64bit target platforms, or if they want to restrict all sizes under 32bit, whatever the platform;
- provides a way for user to enable/disable runtime checks on the size values that must be under 32bit.
- tests for conversion functions
Klaim
force-pushed
the
32bits
branch
3 times, most recently
from
4fe1985
to
c088b80
Compare
Klaim
force-pushed
the
32bits
branch
3 times, most recently
from
963c5e1
to
392aa48
Compare
|
For info: the ci runs that use vcpkg are currently affected by microsoft/vcpkg#41199 |
|
Status update:
|
- added special conversion functions `to_native_size`, `to_native_offset`
and `to_arrow_length`;
- used these functions where necessary;
- setup options for users to decide
- if they want runtime checks on sizes/lengths/offsets
- if they want to limit possible sizes/lengths/offsets to 32bit
values
…ve sizes (offsets)
|
I believe we should stop working on this until things are more stable. |
DerThorsten
requested changes
Oct 10, 2024
|
Most of the conflicts in this PR come from the merge of #225 that removed old layouts and related stuff, on which this PR was started. Porting the changes to the new arrays is not that much work, and solving the conflicts will mostly be dropping the changes from files that have been deleted. |
|
Sorry if my previous comments sounded a bit rude. I am just always a bit alarmed when I see many files in conflict ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.