Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update common tests #52

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Update common tests #52

merged 1 commit into from
Feb 23, 2023

Conversation

ayrat555
Copy link
Member

This pr simplifies decoding logic. The code has worse performance but better maintainability

@ayrat555
Update common tests
7cfa70b 
This pr simplifies decoding logic. The code has worse performance but
better maintainability
@ayrat555
Copy link
Member Author

ayrat555 commented Feb 21, 2023 •
edited
Loading

@InoMurko what do you think? the main reasoning behind this pr is that in the previous state of the library some new tests were failing. and to fix them, it would take 1k changes

plus it would be much harder to implement - #53

@ayrat555 ayrat555 merged commit 60b8fe6 into master Feb 23, 2023
@ayrat555 ayrat555 deleted the ayrat555/simplify branch February 23, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InoMurko InoMurko Awaiting requested review from InoMurko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ayrat555