Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update libsecp256k1, remove libsecp256k1 build instructions #371

Merged
merged 8 commits into from
Aug 22, 2018
Merged

update libsecp256k1, remove libsecp256k1 build instructions #371

merged 8 commits into from
Aug 22, 2018

Conversation

ayrat555
Copy link
Member

No description provided.

@ghost ghost assigned ayrat555 Aug 21, 2018
@ghost ghost added the status: in progress label Aug 21, 2018
germsvel
germsvel approved these changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@germsvel germsvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me. Did you try cloning the repo and doing a bin/setup to see if the changes to the setup script worked?

@ayrat555
Copy link
Member Author

ayrat555 commented Aug 21, 2018 •
edited
Loading

It's a good opportunity to add setup script to circle ci.

@ayrat555 ayrat555 mentioned this pull request Aug 22, 2018
Merged
@ayrat555 ayrat555 changed the title update libsecp256k1, remove libsecp256k1 build istructions update libsecp256k1, remove libsecp256k1 build instructions Aug 22, 2018
@ayrat555 ayrat555 merged commit a70a867 into master Aug 22, 2018
@ayrat555 ayrat555 deleted the ab-libsecp256k1-fix branch August 22, 2018 08:15
@ghost ghost removed the status: in progress label Aug 22, 2018
@germsvel germsvel mentioned this pull request Aug 27, 2018
Closed
@ayrat555 ayrat555 mentioned this pull request Sep 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germsvel germsvel germsvel approved these changes

@masonforest masonforest Awaiting requested review from masonforest

Assignees

@ayrat555 ayrat555

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayrat555 @germsvel