triple check image is at least valid url

manawiki · Oct 21, 2024 · a207af5 · a207af5
1 parent 04087d8
commit a207af5
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/app/components/Image.tsx b/app/components/Image.tsx
@@ -66,7 +66,11 @@ export function Image({
             width={width ?? searchParams.get("width") ?? undefined}
             height={height ?? searchParams.get("height") ?? undefined}
             alt={alt}
-            src={url ? `${url}?${searchParams.toString()}` : "/favicon.ico"}
+            src={
+               url && URL.canParse(url)
+                  ? `${url}?${searchParams.toString()}`
+                  : "/favicon.ico"
+            }
          />
       );
 
@@ -111,7 +115,11 @@ export function Image({
          alt={alt}
          sizes={srcSet ? `(min-width: 1200px) 728px, 100vw` : undefined}
          srcSet={srcSet}
-         src={url ? `${url}?${searchParams.toString()}` : "/favicon.ico"}
+         src={
+            url && URL.canParse(url)
+               ? `${url}?${searchParams.toString()}`
+               : "/favicon.ico"
+         }
       />
    );
 }