Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Strict Version Checking #14

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Meltie2013
Copy link
Contributor

@Meltie2013 Meltie2013 commented Aug 3, 2021

This will need some decent testing to make sure we can login valid clients (e.g untouched clients) as the day you downloaded it to play on the official servers.

Original Commit from TrinityCore: TrinityCore/TrinityCore@250fcc8

Changes Made:

  • Implement version checking for clients to make sure they are not modified. (e.g. signature wise and/or hacked)

How to Test:

  • Enable the version checking in the realmd.conf and attempt to login. If you make it past the login screen, your client is valid.
    If not, you'll be greeted with a version error message.

Disclaimer:

  • Not every client version has a seed to verify if the client is valid or not. Please keep that in mind.

Testing Changes:

  • If you like to test these changes before directly merging these into master branches, input these commands down below.
git fetch origin pull/14/head:strict_version_checking
git checkout strict_version_checking

Note: Feed back is needed and possible changes.


This change is Reviewable

Realm/RealmList.cpp Outdated Show resolved Hide resolved
* disable strict version check by default
Copy link
Member

@billy1arm billy1arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/mangoszero/server/blob/master/cmake/MangosParams.cmake#L4

Will need to be changed when this is pushed to flag that there are new settings in the .conf file

@billy1arm
Copy link
Member

@Meltie2013 - Somehow i'd completely missed this PR. Did you ever get any feedback at all ?

@Meltie2013
Copy link
Contributor Author

@billy1arm I completely forgot about this PR 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants