-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial attempt to merge playerbots from zero into two #188
base: master
Are you sure you want to change the base?
Conversation
Bots module compiles and loads from config as expected (now that I've setup my project with the correct directory structure: binary in /usr/local/bin and configs in /usr/local/etc). Pulled in some code from https://github.com/celguar/mangosbot-bots to fill out the deathknight logic. As per @Foereaper the modules need additional TLC across all cores. |
@leprasmurf checked and eliminated most of the complaints the checks had, there are two mediums remaining: https://app.codacy.com/gh/mangostwo/server/pullRequest?prid=9108498 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 606 of 614 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @leprasmurf)
Most of the changes are pulled from mangoszero/server@ee33683 or mangos zero HEAD.
Whitespace and buffer overflow fix (PR checks)
Pull in some of the updates from Celguar's playerbot repo.
Post-increments converted to pre-increments for efficiency
* Convert <string>.find -> <string>.starts_with * Pass string by constant reference instead of value * Pre-increment in the for loop post-action
* Built-in and module auctionhouse bots conflict on the .ahbot command. Reconfigure module integration for .auctionbot command and finish integrating. * cppcheck fixes * Bot module documentation
Player, Random, and the Auction House Bots are all building and configurable. The ahbot module config disables the built-in ahbot's buyer and seller agents before enabling its own. There is a final assertion that I've yet to track down:
Otherwise the auction house bot responds to the console or chat commands |
There's a memory leak in here somewhere, my instance crashes within 24 hours of running. I'm going to recompile with the |
Is this partly merged? |
Most of the changes are pulled from mangoszero/server@ee33683 or mangos zero HEAD.
WIP:
Almost there, compilation fails towards the end
This change is