-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ConsistencyFailureFunc for auditLogs/SignIns #108
Merged
manicminer
merged 15 commits into
manicminer:main
from
MarkDordoy:md/retry-on-signin-logs-list
Sep 28, 2021
Merged
Add ConsistencyFailureFunc for auditLogs/SignIns #108
manicminer
merged 15 commits into
manicminer:main
from
MarkDordoy:md/retry-on-signin-logs-list
Sep 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for signin logs
MarkDordoy
changed the title
Md/retry on signin logs list
Add ConsistencyFailureFunc for auditLogs/SignIns
Sep 27, 2021
manicminer
added
api-bug
Issue caused by API bug or fix to workaround an API bug
enhancement
New feature or request
package/msgraph
labels
Sep 27, 2021
manicminer
approved these changes
Sep 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MarkDordoy, this LGTM ☁️
manicminer
added a commit
to kaovd/hamilton
that referenced
this pull request
Sep 30, 2021
* Add support for ConsistencyFailure retry with unknown error response * Update naming * testing / re-trigger for failed test * Revert "testing / re-trigger for failed test" This reverts commit fbde76a. * Trim whitespace Co-authored-by: Mark Dordoy <[email protected]> Co-authored-by: Tom Bamford <[email protected]>
manicminer
added a commit
to kaovd/hamilton
that referenced
this pull request
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api-bug
Issue caused by API bug or fix to workaround an API bug
enhancement
New feature or request
package/msgraph
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've discovered doing an odata query such as:
for the most part works, but occasionally comes back with:
After chatting with @manicminer we decided we should look for this and attempt to handle it.