Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ConsistencyFailureFunc for auditLogs/SignIns #108

Merged
merged 15 commits into from
Sep 28, 2021
Merged

Add ConsistencyFailureFunc for auditLogs/SignIns #108

merged 15 commits into from
Sep 28, 2021

Conversation

MarkDordoy
Copy link
Contributor

@MarkDordoy MarkDordoy commented Sep 27, 2021 •
edited
Loading

I've discovered doing an odata query such as:

Filter: fmt.Sprintf("userId eq '%s' and status/ErrorCode eq 0 and (signInEventTypes/any(s:s eq 'nonInteractiveUser') or signInEventTypes/any(s:s eq 'InteractiveUser'))", *user.ID),

for the most part works, but occasionally comes back with:

Failed to get sign in logs from tenant e4529dd5-4156-46ab-a8b0-********** when searching for user [email protected]: SignInLogsClient.BaseClient.Get(): unexpected status 400 with OData error: UnknownError: Unsupported Query.

After chatting with @manicminer we decided we should look for this and attempt to handle it.

@MarkDordoy MarkDordoy changed the title Md/retry on signin logs list Add ConsistencyFailureFunc for auditLogs/SignIns Sep 27, 2021
@manicminer manicminer added api-bug Issue caused by API bug or fix to workaround an API bug enhancement New feature or request package/msgraph labels Sep 27, 2021
@manicminer manicminer added this to the v0.31.0 milestone Sep 27, 2021
@manicminer manicminer self-requested a review September 27, 2021 11:42
manicminer
manicminer approved these changes Sep 27, 2021
View reviewed changes
Copy link
Owner

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MarkDordoy, this LGTM ☁️

msgraph/sign_in_reports.go Outdated Show resolved Hide resolved
@manicminer manicminer merged commit 678acc0 into manicminer:main Sep 28, 2021
manicminer added a commit that referenced this pull request Sep 28, 2021
@manicminer
Changelog for #108
5e24d09
manicminer added a commit to kaovd/hamilton that referenced this pull request Sep 30, 2021
@MarkDordoy @manicminer
Add ConsistencyFailureFunc for auditLogs/SignIns (manicminer#108)
aee3a49 
* Add support for ConsistencyFailure retry with unknown error response

* Update naming

* testing / re-trigger for failed test

* Revert "testing / re-trigger for failed test"

This reverts commit fbde76a.

* Trim whitespace

Co-authored-by: Mark Dordoy <[email protected]>
Co-authored-by: Tom Bamford <[email protected]>
manicminer added a commit to kaovd/hamilton that referenced this pull request Sep 30, 2021
@manicminer
Changelog for manicminer#108
6a4749e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manicminer manicminer manicminer approved these changes

Assignees
No one assigned
Labels
api-bug Issue caused by API bug or fix to workaround an API bug enhancement New feature or request package/msgraph
Projects
None yet
Milestone
v0.31.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkDordoy @manicminer