Managed Identity: Support specifying the client ID when requesting a token from the metadata service #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…token from the metadata service
manicminer
added
enhancement
manicminer
requested review from
koikonom,
tombuildsstuff,
katbyte and
jackofallops
jackofallops
approved these changes
Oct 13, 2021
| @@ -31,14 +31,18 @@ func (a *MsiAuthorizer) Token() (*oauth2.Token, error) { | |||
| "api-version": []string{a.conf.MsiApiVersion}, | |||
| "resource": []string{a.conf.Resource}, | |||
| } | |||
|
|
|||
| if a.conf.ClientID != "" { | |||
There was a problem hiding this comment.
Is there a chance conf can ever be nil here?
There was a problem hiding this comment.
Good catch, will add checks 👍
tombuildsstuff
approved these changes
Oct 13, 2021
| @@ -76,13 +80,22 @@ func (a *MsiAuthorizer) Token() (*oauth2.Token, error) { | |||
|
|
|||
| // MsiConfig configures an MsiAuthorizer. | |||
| type MsiConfig struct { | |||
| // ClientID is optionally used to determine which application to assume when a resource has multiple managed identities | |||
| ClientID string | |||
There was a problem hiding this comment.
since this is an optional value I'd suggest this should be a pointer rather than checking != ""?
There was a problem hiding this comment.
Good shout, this is a pattern used in all the authorizers - will look at improving this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: breaking change for the
auth.NewMsiAuthorizer()andauth.NewMsiConfig()functionsRelated: hashicorp/terraform-provider-azuread#604