Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing environment API configurations #129

Merged
merged 2 commits into from
Nov 29, 2021

Conversation

manicminer
Copy link
Owner

@manicminer manicminer commented Nov 26, 2021

Also add an IsAvailable() convenience method for environments with no support for a particular service/endpoint

@manicminer manicminer added bug Something isn't working package/environments labels Nov 26, 2021
@manicminer manicminer added this to the v0.37.0 milestone Nov 26, 2021
Copy link
Collaborator

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment but this otherwise LGTM 👍

environments/apis.go Outdated Show resolved Hide resolved
@manicminer manicminer merged commit 27040ad into main Nov 29, 2021
@manicminer manicminer deleted the bugfix/missing-environment-endpoints branch November 29, 2021 11:23
manicminer added a commit that referenced this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package/environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants