-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for authenticating via GitHub OIDC #142
Conversation
1528024
to
7f26c28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the audience required by Azure is missing
Thanks @simongottschlag! I was staring at this for too long and my brain could not do the diff :D |
fb41912
to
cb40790
Compare
d54c681
to
e746418
Compare
e746418
to
dc03205
Compare
dc03205
to
5b4971b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
The GHA workflow that tests this runs on a hosted runner and is already committed to main, for testing this PR, and also includes a step that runs the azure/login action for validating that the same backend configuration is valid for the GitHubOIDCAuthorizer test. The azure/login action is not needed for this support to work, it's only being run for comparison.
Docs References: