Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on cloud runners #145

Merged
merged 4 commits into from
Jan 31, 2022
Merged

Conversation

manicminer
Copy link
Owner

@manicminer manicminer commented Jan 30, 2022

  • Support for selecting GitHub OIDC authentication when using the auth.NewAuthorizer() helper function
  • Bump supported Go version to 1.17.6

Run all tests on cloud hosted GHA runners.

msgraph tests now use GitHub OIDC authentication to acquire a token for creating/deleting test resources.

Uses different credentials for testing client credentials auth flow and Azure CLI auth - as these are now stored in GH secrets they can potentially be leaked but they have no meaningful roles or scopes assigned so are powerless to do anything.

@manicminer manicminer force-pushed the testing/github-oidc-with-cloud-runners branch 3 times, most recently from 2e4d56b to 4d4e012 Compare January 30, 2022 23:25
@manicminer manicminer force-pushed the testing/github-oidc-with-cloud-runners branch from 4d4e012 to ca0ce47 Compare January 30, 2022 23:32
@manicminer manicminer force-pushed the testing/github-oidc-with-cloud-runners branch from f30aaae to 91a4ba0 Compare January 31, 2022 00:06
@manicminer manicminer added this to the v0.41.0 milestone Jan 31, 2022
@manicminer manicminer changed the title Run auth tests on cloud runner Run tests on cloud runners Jan 31, 2022
Copy link
Collaborator

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manicminer manicminer merged commit 3357b79 into main Jan 31, 2022
@manicminer manicminer deleted the testing/github-oidc-with-cloud-runners branch January 31, 2022 12:16
manicminer added a commit that referenced this pull request Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package/auth tests Includes tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants