Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix App ID URI for Vault in USGovernment cloud #157

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Fix App ID URI for Vault in USGovernment cloud #157

merged 1 commit into from
Apr 19, 2022

Conversation

manicminer
Copy link
Owner

@manicminer manicminer commented Apr 14, 2022 •
edited
Loading

@manicminer manicminer added bug Something isn't working package/environments labels Apr 14, 2022
@manicminer manicminer added this to the v0.44.0 milestone Apr 14, 2022
@manicminer manicminer requested a review from katbyte April 14, 2022 17:35
jackofallops
jackofallops approved these changes Apr 18, 2022
View reviewed changes
Copy link
Collaborator

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manicminer manicminer merged commit 0e3e3e5 into main Apr 19, 2022
@manicminer manicminer deleted the bugfix/usgov-vault-uri branch April 19, 2022 12:06
manicminer added a commit that referenced this pull request Apr 19, 2022
@manicminer
Changelog for #157
62964cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackofallops jackofallops jackofallops approved these changes

@katbyte katbyte Awaiting requested review from katbyte

@tombuildsstuff tombuildsstuff Awaiting requested review from tombuildsstuff

Assignees
No one assigned
Labels
bug Something isn't working package/environments
Projects
None yet
Milestone
v0.44.0
Development

Successfully merging this pull request may close these issues.
2 participants
@manicminer @jackofallops