Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for B2CUserFlow CRUD operations #179

Merged
merged 6 commits into from
Sep 29, 2022

Conversation

jarifibrahim
Copy link
Contributor

@jarifibrahim jarifibrahim commented Sep 21, 2022

Related to hashicorp/terraform-provider-azuread#175
This commit adds the following

  • B2CUserFlowClient for interacting with /identity/b2cuserflow endpoint
  • B2CUserFlow model for the request/response payload
  • Some tests for the CRUD operations

This commit adds the following
- B2CUserFlowClient for interacting with /identity/b2cuserflow endpoint
- B2CUserFlow model for the request/response payload
- Some tests for the CRUD operations
UNKNOWNFUTUREVALUE_USERFLOWTYPE
)

type B2CUserFlow struct {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

B2cUserFlow has a bunch of fields https://learn.microsoft.com/en-us/graph/api/resources/b2cidentityuserflow?view=graph-rest-beta . I've added only the minimal ones.

I can add more fields if required.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will want to add these in time, but I'm happy to merge with these fields for now.

@jarifibrahim
Copy link
Contributor Author

Hello @manicminer 👋 ! Can you please review this PR?

Copy link
Owner

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jarifibrahim Thanks for this contribution! This mostly LGTM, it just looks like an errant file made it into the commit history. If you can fix that then this should be good to merge.

UNKNOWNFUTUREVALUE_USERFLOWTYPE
)

type B2CUserFlow struct {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will want to add these in time, but I'm happy to merge with these fields for now.

;qa Outdated Show resolved Hide resolved
@manicminer manicminer added this to the v0.48.0 milestone Sep 29, 2022
@manicminer manicminer merged commit dd59f41 into manicminer:main Sep 29, 2022
manicminer added a commit that referenced this pull request Sep 29, 2022
@jarifibrahim jarifibrahim deleted the userflow-support branch October 4, 2022 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants