Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quick fixes for two issues: nil pointer and type mismatch #187

Merged
merged 3 commits into from
Oct 27, 2022
Merged

quick fixes for two issues: nil pointer and type mismatch #187

merged 3 commits into from
Oct 27, 2022

Conversation

stanleyz
Copy link

@stanleyz stanleyz commented Oct 7, 2022 •
edited
Loading

This PR fixes two issues:

  1. type mis-match for "Description" field of "AccessPackageResource", reference: https://learn.microsoft.com/en-us/graph/api/resources/accesspackageresource?view=graph-rest-beta
    This is introduced recently.
  2. For AccessPackageResource, when there is no match on Azure, AccessPackageResources will be an empty array, hence the fix

@stanleyz stanleyz changed the title Fix the situation where there is no match Fix the situation where there is no match for AccessPackageResources Oct 7, 2022
@stanleyz stanleyz mentioned this pull request Oct 7, 2022
Merged
@stanleyz stanleyz changed the title Fix the situation where there is no match for AccessPackageResources quick fixes for two issues: nil pointer and type mismatch Oct 13, 2022
@stanleyz
Copy link
Author

stanleyz commented Oct 13, 2022 •
edited
Loading

@kaovd @manicminer can you please take a look and merge this quickly? Thanks.

They are all quick simple bugs/fixes as I understand.

@manicminer manicminer added bug Something isn't working package/msgraph labels Oct 13, 2022
manicminer
manicminer approved these changes Oct 13, 2022
View reviewed changes
Copy link
Owner

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stanleyz for these bugfixes!

@manicminer manicminer added this to the v0.51.0 milestone Oct 13, 2022
@stanleyz
Copy link
Author

Thanks @manicminer. The golang-lint workflow error here https://github.com/manicminer/hamilton/actions/runs/3238793336/jobs/5324839976 seems not related to this PR, but it does reveal an excessive check on my local, which I've fixed in the additional commit.

@manicminer
Copy link
Owner

Rebased for test fixes

@manicminer manicminer merged commit a8b85d5 into manicminer:main Oct 27, 2022
manicminer added a commit that referenced this pull request Oct 27, 2022
@manicminer
Changelog for #187
2c7594b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manicminer manicminer manicminer approved these changes

Assignees
No one assigned
Labels
bug Something isn't working package/msgraph
Projects
None yet
Milestone
v0.51.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stanleyz @manicminer