Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use eq rather than startswith which returns a list of resources #194

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

stanleyz
Copy link

@stanleyz stanleyz commented Nov 5, 2022

The startswith function returns a list of resources, should use eq instead, see below screenshot.

Will add test for accesspackageresource later on quite possibly in a separate PR.

accesspackageresource

@stanleyz
Copy link
Author

@manicminer can you please take a look? Thanks.

Copy link
Owner

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stanleyz, this LGTM

@manicminer manicminer added bug Something isn't working package/msgraph labels Nov 17, 2022
@manicminer manicminer added this to the v0.52.0 milestone Nov 17, 2022
@manicminer manicminer merged commit 2a03750 into manicminer:main Nov 17, 2022
manicminer added a commit that referenced this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package/msgraph
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants