Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WindowsAutopilotDeploymentProfile #228

Conversation

kenchan0130
Copy link
Contributor

@manicminer
Copy link
Owner

Thank you for the PR @kenchan0130. We recently merged an update that removes support for specifying the tenant ID in clients - would you be able to rebase from main and also resolve the conflict in odata/types.go and then I can look at merging this? Thanks!

@kenchan0130
Copy link
Contributor Author

I will fix this PR when hashicorp/go-azure-sdk#342 changes are released.

@kenchan0130 kenchan0130 force-pushed the patch-windows-autopilot-deployment-profiles branch from efb8211 to 99cc5c0 Compare March 22, 2023 14:58
@kenchan0130
Copy link
Contributor Author

@manicminer I have made revisions based on your feedback. Please review the changes once more.

@kenchan0130 kenchan0130 force-pushed the patch-windows-autopilot-deployment-profiles branch from b5203de to 75a2fe4 Compare March 28, 2023 15:54
Copy link
Owner

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @kenchan0130. Sorry for the delay in reviewing, this LGTM 👍

@kenchan0130
Copy link
Contributor Author

@manicminer
Thank you for your review.

Application is not authorized to perform this operation. Application must have one of the following scopes: DeviceManagementServiceConfiguration.ReadWrite.All, DeviceManagementServiceConfig.ReadWrite.All

From the errors in the test at CI, it seems that the Application used in the tests does not have enough permissions.
I think that if you grant permissions, the tests that are failing will probably succeed.

@manicminer manicminer added this to the v0.60.0 milestone Apr 3, 2023
@manicminer manicminer merged commit 4781c92 into manicminer:main Apr 3, 2023
manicminer added a commit that referenced this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request package/msgraph
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants