-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Support for Conditional Access Policy #23
Conversation
@manicminer, this is a draft PR to add API support for conditionalAccessPolicy. I'd like to add some tests for the ConditionalAccessPolicyClient. Can you advise if you have a specific tenant that the tests need to run against? |
Hi @liammoat, thanks for this PR, this looks great! For configuring tests, there is a helper at https://github.com/manicminer/hamilton/blob/main/clients/internal/testing.go which reads the auth configuration from environment variables, so it's up to the user to supply a tenant ID (in this case, for a P1 or P2 tenant) and client credentials. If you can add some tests, I'll take another look and we can look to get this merged :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liammoat Thanks for adding the tests. This mostly LGTM, I have a question about the enterprise application used for testing, and I replied to your query on the readonly field issue.
Sorry for the inconvenience but I've done some refactoring that affects your PR - the clients
and models
packages are now a single package msgraph
, with the models together alphabetically in models.go
.
I also had to merge the same golangci-lint fix to the GH action so you'll probably need to revert that file.
If you can take a look at the above this should be good to merge. Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @liammoat, this LGTM!
This PR will add API support for conditionalAccessPolicy on the Microsoft Graph.