Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop tenant ID from path in Microsoft Graph requests #230

Merged
merged 5 commits into from
Feb 27, 2023
Merged

Drop tenant ID from path in Microsoft Graph requests #230

merged 5 commits into from
Feb 27, 2023

Conversation

manicminer
Copy link
Owner

Drop the tenant ID from Microsoft Graph endpoint URIs, as this is deprecated and no longer needed with MSAL.

Related: hashicorp/go-azure-sdk#310

@manicminer manicminer added enhancement New feature or request package/msgraph labels Feb 23, 2023
@manicminer manicminer added this to the v0.59.0 milestone Feb 23, 2023
tombuildsstuff
tombuildsstuff approved these changes Feb 24, 2023
View reviewed changes
Copy link
Collaborator

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we can remove the tenantId argument from the NewClient methods? Otherwise LGTM

msgraph/accesspackage.go Outdated Show resolved Hide resolved
msgraph/accesspackageassignmentpolicy.go Outdated Show resolved Hide resolved
msgraph/accesspackageassignmentrequest.go Outdated Show resolved Hide resolved
msgraph/accesspackagecatalog.go Outdated Show resolved Hide resolved
msgraph/accesspackageresource.go Outdated Show resolved Hide resolved
msgraph/sign_in_reports.go Outdated Show resolved Hide resolved
msgraph/synchronization.go Outdated Show resolved Hide resolved
msgraph/termsofuse.go Outdated Show resolved Hide resolved
msgraph/userflow_attributes.go Outdated Show resolved Hide resolved
msgraph/users.go Outdated Show resolved Hide resolved
@manicminer manicminer merged commit b5cbc38 into main Feb 27, 2023
@manicminer manicminer deleted the drop-tenantid-from-path branch February 27, 2023 17:49
manicminer added a commit that referenced this pull request Feb 27, 2023
@manicminer
Changelog for #230
ca2197c
@manicminer manicminer mentioned this pull request Mar 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request package/msgraph
Projects
None yet
Milestone
v0.59.0
Development

Successfully merging this pull request may close these issues.
2 participants
@manicminer @tombuildsstuff