Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ServicePrincipalRiskLevels to ConditionalAccessConditionSet #246

Merged
merged 3 commits into from
Jul 14, 2023

Conversation

bubbletroubles
Copy link
Contributor

@bubbletroubles bubbletroubles commented Jul 8, 2023

Added ServicePrincipalRiskLevels to ConditionalAccessConditionSet

Created a new value type for ConditionalAccessServicePrincipalRiskLevel as Service Principles don't have the hidden value which is currently in ConditionalAccessRiskLevel - see Graph API v1.0 documentation

Copy link
Owner

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @bubbletroubles. Although the servicePrincipalRiskLevels field doesn't support that value, it is still the same object so we should use the ConditionalAccessRiskLevel type. I'll go ahead and update this so we can merge in the additional field.

@manicminer manicminer added enhancement New feature or request package/msgraph labels Jul 14, 2023
@manicminer manicminer added this to the v0.62.0 milestone Jul 14, 2023
@manicminer manicminer merged commit 6dc1201 into manicminer:main Jul 14, 2023
2 checks passed
manicminer added a commit that referenced this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request package/msgraph
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants