Feature - Add support for Custom Security Attributes #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brendan Thompson <[email protected]>
Signed-off-by: Brendan Thompson <[email protected]>
manicminer
requested changes
May 16, 2024
There was a problem hiding this comment.
Thanks @BrendanThompson! As discussed in private, for the attribute sets if we can name them predictably and only create when absent, this will avoid running the tenant-wide limit. For attributes, we should deactivate them at the end of the test as these don't contribute towards the limit. Other than that, this LGTM and should be good to go with those changes 👍
Signed-off-by: Brendan Thompson <[email protected]>
Signed-off-by: Brendan Thompson <[email protected]>
Signed-off-by: Brendan Thompson <[email protected]>
Signed-off-by: Brendan Thompson <[email protected]>
- `AttributeSet` cannot have a digit as the first character in the name, this change ensures that never happens Signed-off-by: Brendan Thompson <[email protected]>
- Creation of new `AttributeSet` will only occur when environment variable is set - Added to the `Test` struct Signed-off-by: Brendan Thompson <[email protected]>
- If not set `hamilton` is the default Signed-off-by: Brendan Thompson <[email protected]>
manicminer
approved these changes
May 17, 2024
There was a problem hiding this comment.
Thanks for making the updates @BrendanThompson, this LGTM 🚀
|
Test failure is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add:
attribute setscustom security attribute definitions