Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for app role assignments to groups #32

Merged
merged 3 commits into from
Apr 21, 2021

Conversation

michaljirman
Copy link
Contributor

This PR adds basic support for app role assignments to a group:

  • list group's assigned app roles
  • remove assigned app role from a group
  • assign app role to a group

Resources:

@manicminer manicminer added the enhancement New feature or request label Apr 21, 2021
@manicminer manicminer added this to the v0.12.0 milestone Apr 21, 2021
Copy link
Owner

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @michaljirman, this LGTM!

@manicminer manicminer merged commit 0693042 into manicminer:main Apr 21, 2021
manicminer added a commit that referenced this pull request Apr 21, 2021
@michaljirman
Copy link
Contributor Author

@manicminer
Np, thanks for merging. Btw. have you received any of my emails?

@manicminer
Copy link
Owner

@michaljirman yes i did, sorry for the delay but I replied just now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants