add support for sending emails #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaljirman
force-pushed
the
feature/support-send-email
branch
from
78283ec
to
8cd605e
Compare
|
Thanks @michaljirman, this is looking good! Could you add a test for each of those client methods? |
|
@manicminer I was thinking about it but it gets quite tricky to test. You need to use a special user with an ms365 licence for this. I am not sure how to create such a test user. |
manicminer
approved these changes
May 4, 2021
There was a problem hiding this comment.
@michaljirman That makes sense. Let's merge it without a test for now, and we can look at supporting tests with user principals (most likely using Azure CLI as mechanism) as there are going to be more resources with this requirement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for sending emails; tiny