Get deleted API for apps, groups, and users #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manicminer
approved these changes
May 27, 2021
There was a problem hiding this comment.
Thanks again for this @tsologub. I think this approach is fine for now. I've been thinking about improving handling of generic directory objects but I feel this needs a few use cases first to get it right. Some code duplication is perfectly ok if it reads or works better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for retrieving deleted applications, groups, and users. (i.e. basically this page)
Notes to the reviewer:
I wasn't quite sure how to approach this, as it is basically a code duplication. The HTTP request is the same (
/directory/deletedItems), but different types will be returned in the end. I was thinking of introducing amsgraph/directory.gowithGetDeleted(), but that didn't feel right. So I decided to keep this decoupled under separate clients, even if it is a code duplication somehow.p.s. Groups without tests for the same (#48) reason.