-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support For Sign-in,Directory Audit get/list actions and Create/List/Delete for Application Extensions #61
Add Support For Sign-in,Directory Audit get/list actions and Create/List/Delete for Application Extensions #61
Conversation
Tests past locally for me now. However the List SigninLogs can error out (this is dependent on how busy the tenant is and how many sign in logs there are to list).
I think if we could get that working then i could ask the test to always just bring back top 1 so we get a speedy test. @manicminer if you have any thoughts/idea's on this let me know. |
Hey @manicminer do i need to add anything else to get this approved and merged? Do you have any suggestions in terms of the tests to try and reduce the time and have the call just ask for the top 1? |
…sort the model structs for readability
Hey @MarkDordoy, sorry for the delay in reviewing. The func (c *SignInReportsClient) List(ctx context.Context, filter string, top int) (*[]SignInReport, int, error) {
params := url.Values{}
if filter != "" {
params.Add("$filter", filter)
}
if top > 0 {
params.Add("$top", fmt.Sprintf("%d", top))
} This isn't very wieldy though - there are lots of requests that support $top and I don't think it'd be nice to add another argument to a load of client methods. I'm not entirely happy about the That aside, this PR looks great. I made a few small changes locally - I renamed the Could you enable upstream contributions for this PR and I'll push my changes, then we can get this merged? Many thanks for the contribution! :) |
Hey @manicminer I've selected the "Allow edits by maintainers" button in this PR, i think thats what you need to be able to push commits. Let me know if it doesnt work |
Thanks, that did it - I also had your branch name wrong 😅 |
This PR extends the models.go file to contain the required structs for SignInLogs, DirectoryAuditLogs and application extensions.
It also has some basic tests which should be able to perform get and list on directory audit and signin logs as well as create, list and delete for application Extensions