Support for generic directory objects and improved odata field handling #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds a top level model struct for the directoryObject API base class - Embed this struct into other models to inherit the ID and odata fields - Support operations via the /directoryObjects endpoint - Improved handling of @odata.bind fields so that the tenant ID isn't needed to build odata URIs for objects
manicminer
force-pushed
the
f/directory-objects
branch
from
932ceaf
to
8c8ec5e
Compare
tombuildsstuff
approved these changes
Aug 13, 2021
Comment on lines
+22
to
+41
| c := DirectoryObjectsClientTest{ | ||
| connection: test.NewConnection(auth.MsGraph, auth.TokenVersion2), | ||
| randomString: rs, | ||
| } | ||
| c.client = msgraph.NewDirectoryObjectsClient(c.connection.AuthConfig.TenantID) | ||
| c.client.BaseClient.Authorizer = c.connection.Authorizer | ||
|
|
||
| g := GroupsClientTest{ | ||
| connection: test.NewConnection(auth.MsGraph, auth.TokenVersion2), | ||
| randomString: rs, | ||
| } | ||
| g.client = msgraph.NewGroupsClient(c.connection.AuthConfig.TenantID) | ||
| g.client.BaseClient.Authorizer = c.connection.Authorizer | ||
|
|
||
| u := UsersClientTest{ | ||
| connection: test.NewConnection(auth.MsGraph, auth.TokenVersion2), | ||
| randomString: rs, | ||
| } | ||
| u.client = msgraph.NewUsersClient(c.connection.AuthConfig.TenantID) | ||
| u.client.BaseClient.Authorizer = c.connection.Authorizer |
There was a problem hiding this comment.
it might be worth adding some test-wrappers here?
Comment on lines
+74
to
+79
| testDirectoryObjectsClient_Get(t, c, *user.ID) | ||
| testDirectoryObjectsClient_Get(t, c, *group1.ID) | ||
| testDirectoryObjectsClient_GetMemberGroups(t, c, *user.ID, true, []string{*group1.ID, *group2.ID}) | ||
| testDirectoryObjectsClient_GetMemberObjects(t, c, *group1.ID, true, []string{*group2.ID}) | ||
| testDirectoryObjectsClient_GetByIds(t, c, []string{*group1.ID, *group2.ID, *user.ID}, []string{odata.ShortTypeGroup}) | ||
| testDirectoryObjectsClient_Delete(t, c, *group1.ID) |
There was a problem hiding this comment.
using something like Testify's suite package would make this easier fwiw (since these'd be methods hanging off of that struct with a Setup, as your doing here?)
There was a problem hiding this comment.
cool, will take a look at that and improving the test setup sprawl 👍
katbyte
approved these changes
Aug 13, 2021
Comment on lines
+22
to
+41
| c := DirectoryObjectsClientTest{ | ||
| connection: test.NewConnection(auth.MsGraph, auth.TokenVersion2), | ||
| randomString: rs, | ||
| } | ||
| c.client = msgraph.NewDirectoryObjectsClient(c.connection.AuthConfig.TenantID) | ||
| c.client.BaseClient.Authorizer = c.connection.Authorizer | ||
|
|
||
| g := GroupsClientTest{ | ||
| connection: test.NewConnection(auth.MsGraph, auth.TokenVersion2), | ||
| randomString: rs, | ||
| } | ||
| g.client = msgraph.NewGroupsClient(c.connection.AuthConfig.TenantID) | ||
| g.client.BaseClient.Authorizer = c.connection.Authorizer | ||
|
|
||
| u := UsersClientTest{ | ||
| connection: test.NewConnection(auth.MsGraph, auth.TokenVersion2), | ||
| randomString: rs, | ||
| } | ||
| u.client = msgraph.NewUsersClient(c.connection.AuthConfig.TenantID) | ||
| u.client.BaseClient.Authorizer = c.connection.Authorizer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amongst other benefits, this should enable us to determine the type of an object given its UUID.