Password policies use nullable strings #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manicminer
approved these changes
Sep 7, 2021
There was a problem hiding this comment.
@alexwilcox9 Thanks for this fix. We don't have test coverage for every field yet so there's nothing else to update.
manicminer
added
breaking change
manicminer
pushed a commit
to kaovd/hamilton
that referenced
this pull request
Sep 30, 2021
Co-authored-by: Alex Wilcox <[email protected]>
manicminer
added a commit
to kaovd/hamilton
that referenced
this pull request
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing
PasswordPoliciesto typeStringNullWhenEmptyso it can be successfully updatedSee hashicorp/terraform-provider-azuread#550 for context
@manicminer what tests if any need to be created/updated for this PR?