Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the right base64 decoder as a JWT is a tuple of URL-safe base64 encoded strings #97

Merged
merged 2 commits into from
Sep 9, 2021
Merged

Use the right base64 decoder as a JWT is a tuple of URL-safe base64 encoded strings #97

merged 2 commits into from
Sep 9, 2021

Conversation

moriyoshi
Copy link
Contributor

@moriyoshi moriyoshi commented Sep 8, 2021 •
edited
Loading

This causes hashicorp/terraform-provider-azuread#558 .

SIDENOTE: the implementation doesn't verify the attached signature and this needs to be addressed.

@moriyoshi moriyoshi mentioned this pull request Sep 8, 2021
Closed
@manicminer manicminer added bug Something isn't working package/auth labels Sep 8, 2021
@manicminer manicminer added this to the v0.28.1 milestone Sep 8, 2021
@manicminer
Copy link
Owner

manicminer commented Sep 8, 2021 •
edited
Loading

Hi @moriyoshi, thanks for spotting and fixing this! I added some tests for auth.ParseClaims() for some extra safety around this as it has become a critical function.

jackofallops
jackofallops approved these changes Sep 9, 2021
View reviewed changes
Copy link
Collaborator

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@manicminer manicminer merged commit f3fce73 into manicminer:main Sep 9, 2021
manicminer added a commit that referenced this pull request Sep 9, 2021
@manicminer
Changelog for #97
2a6493c
manicminer added a commit to kaovd/hamilton that referenced this pull request Sep 30, 2021
@manicminer
Changelog for manicminer#97
3013510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackofallops jackofallops jackofallops approved these changes

@katbyte katbyte Awaiting requested review from katbyte

Assignees
No one assigned
Labels
bug Something isn't working package/auth
Projects
None yet
Milestone
v0.28.1
Development

Successfully merging this pull request may close these issues.
3 participants
@moriyoshi @manicminer @jackofallops