Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to detect Azure Cloud Shell and avoid specifying the tenant ID for Azure CLI authentication #98

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Try to detect Azure Cloud Shell and avoid specifying the tenant ID for Azure CLI authentication #98

merged 1 commit into from
Sep 9, 2021

Conversation

manicminer
Copy link
Owner

@manicminer manicminer added bug Something isn't working package/auth labels Sep 8, 2021
@manicminer manicminer added this to the v0.28.1 milestone Sep 8, 2021
katbyte
katbyte approved these changes Sep 8, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏗️

@manicminer manicminer merged commit 9a433ce into main Sep 9, 2021
@manicminer manicminer deleted the bugfix/cli-auth-cloud-shell branch September 9, 2021 11:15
manicminer added a commit that referenced this pull request Sep 9, 2021
@manicminer
Changelog for #98
3ef2a11
manicminer added a commit to kaovd/hamilton that referenced this pull request Sep 30, 2021
@manicminer
Changelog for manicminer#98
e73a590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katbyte katbyte katbyte approved these changes

@jackofallops jackofallops Awaiting requested review from jackofallops

Assignees
No one assigned
Labels
bug Something isn't working package/auth
Projects
None yet
Milestone
v0.28.1
Development

Successfully merging this pull request may close these issues.
2 participants
@manicminer @katbyte