Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package for conda forge #154

Closed
jtpio opened this issue Jan 4, 2021 · 3 comments
Closed

Package for conda forge #154

jtpio opened this issue Jan 4, 2021 · 3 comments

Comments

@jtpio
Copy link

jtpio commented Jan 4, 2021

Opening the issue here, but the packaging would be done in https://github.com/conda-forge/staged-recipes

It would be nice if jupyter-offlinenotebook could be made available on conda forge too.

It looks like this would make it possible to list jupyter-offlinenotebook as part of the environment in the repo2docker buildpack directly?

https://github.com/jupyterhub/repo2docker/blob/560b1d96a0e39cb8de53cb41a7c2d8d23384eb82/repo2docker/buildpacks/conda/environment.yml#L2-L9

@manics
Copy link
Owner

manics commented Jan 4, 2021

It's already in conda-forge thanks to @xhochy 😄 jupyterhub/repo2docker#846
Based on that discussion it sounds like switching from pip to conda when we switch to JupyterLab 3 package makes sense. I'll release 0.2.0 to pypi, update and test the feedstock, and let you know!

@jtpio
Copy link
Author

jtpio commented Jan 4, 2021

Perfect, thanks!

@jtpio
Copy link
Author

jtpio commented Jan 4, 2021

Closing, and we can switch to installing it from conda in repo2docker then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants