Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install jupyter-offlinenotebook from conda-forge #846

Closed
wants to merge 1 commit into from

Conversation

xhochy
Copy link
Contributor

@xhochy xhochy commented Feb 6, 2020

No description provided.

@xhochy xhochy requested a review from betatim February 6, 2020 21:45
@betatim
Copy link
Member

betatim commented Feb 7, 2020

Thanks for making the conda forge recipe!

I had hopes that it would save us the step of rebuilding jupyter lab (which takes a lot of time) but it doesn't :( Do you know if that is even possible?

What is the advantage to using a conda package for this? I like being able to install specific revisions from the GitHub repository so that we can update things straight after merging a PR if we want to.

@xhochy
Copy link
Contributor Author

xhochy commented Feb 7, 2020

I had hopes that it would save us the step of rebuilding jupyter lab (which takes a lot of time) but it doesn't :( Do you know if that is even possible?

As far as I have understood the jupyter lab build system, this is currently impossible as a single JavaScript file for all extensions is produced.

What is the advantage to using a conda package for this? I like being able to install specific revisions from the GitHub repository so that we can update things straight after merging a PR if we want to.

I prefer to have all things installed by conda when using it as an environment manager as it also makes it easier for conda to resolve version conflicts.

As long as you iterate heavily on it, it may be good to leave this PR as it is and revisit in some months.

@betatim
Copy link
Member

betatim commented Feb 7, 2020

Thanks for the thoughts on conda vs pip. I think I am +-0 on sticking with pip or switching to conda for this. Maybe +0 for pip until we get some feedback or time passes without feedback. Then go to using conda.

@manics
Copy link
Member

manics commented Feb 8, 2020

@xhochy thanks for creating the conda-forge package!
https://pypi.org/project/jupyter-offlinenotebook/ doesn't include the jupyterlab support, that's in the NPM package: https://www.npmjs.com/package/jupyter-offlinenotebook
(both share the same source repo though).

I'm not particularly happy with the JupyterLab extension though it seems to work, I think it'd be better to take advantage of the richer UI options (e.g. see jupyterhub/binderhub#987)

@manics
Copy link
Member

manics commented Mar 7, 2021

This was finally done in #996

@manics manics closed this Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants