Update for Jupyterlab 2 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch to Lumino - PartialJSONValue instead of JSONValue - iconName instead of iconClass - panel.content.model may be null
|
|
This was referenced Mar 8, 2020
|
Using the Firefox dev-tools I've found there's a CSS class
The class is defined in Jupyterlab here: |
manics
force-pushed
the
jupyterlab2
branch
2 times, most recently
from
52b7b28
to
d3e590f
Compare
Override an '!important' JupyterLab CSS property
|
The Icons are visible now- tested in Firefox and Chrome. |
betatim
reviewed
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the lab extension for Jupyterlab 2.
Test this branch on mybinder: https://mybinder.org/v2/gh/manics/jupyter-offlinenotebook/jupyterlab2?urlpath=lab%2Ftree%2Fexample.ipynb